[wp-trac] [WordPress Trac] #34528: Responsive Images: Don't add srcset attributes to animated gifs.

[WordPress Trac]

#34528: Responsive Images: Don't add srcset attributes to animated gifs.
--------------------------------------+------------------------
 Reporter:  joemcgill                 |       Owner:  joemcgill
     Type:  defect (bug)              |      Status:  accepted
 Priority:  normal                    |   Milestone:  4.4
Component:  Media                     |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------

Comment (by DH-Shredder):

 Replying to [comment:3 joemcgill]:
 > My patch, [attachment:34528.diff] does specifically target cases where
 the original size is chosen.
 >

 Okay, cool!  Sorry about that; nice.

 > Are a lot of people using animated PNGs? I worry about doing the same
 for PNGs because often times I see people inserting full size PNGs into
 their content that are essentially screenshots with very large file sizes.
 I'd hate to lose `srcset` support for these cases.

 I don't suspect there are many, but want to make sure that we don't break
 user expectations, since this would change displayed user content out from
 under them.

 We may want to (for GIFs/PNGs) exclude the original from`srcset` if the
 `src=` does not reference the original, so that some sizes that were not
 animated before don't magically become animated after the update.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34528#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform