[wp-trac] [WordPress Trac] #30737: JS templates for Customizer Panels and Sections

[WordPress Trac]

#30737: JS templates for Customizer Panels and Sections
------------------------------+--------------------------
 Reporter:  celloexpressions  |       Owner:  westonruter
     Type:  enhancement       |      Status:  accepted
 Priority:  normal            |   Milestone:  4.3
Component:  Customize         |     Version:  4.1
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+--------------------------

Comment (by ocean90):

 With [attachment:30737.12.diff] I get two PHPUnit failures:


 {{{
 There was 1 error:

 1) Tests_WP_Customize_Section::test_json
 Trying to get property of non-object

 /srv/www/wp-develop/svn/src/wp-includes/class-wp-customize-section.php:233
 /srv/www/wp-develop/svn/tests/phpunit/tests/customize/section.php:121

 --

 There was 1 failure:

 1) Tests_WP_Customize_Panel::test_print_templates_standard
 Failed asserting that '         <script type="text/html" id="tmpl-
 customize-panel-default-content">
                                         <li class="panel-meta customize-
 info accordion-section <# if ( ! data.description ) { #> cannot-expand<# }
 #>">
                         <button class="customize-panel-back"
 tabindex="-1"><span class="screen-reader-text">Back</span></button>
                         <div class="accordion-section-title">
                                 <span class="preview-notice">You are
 customizing <strong class="panel-title">{{ data.title }}</strong></span>
                                 <button class="customize-help-toggle
 dashicons dashicons-editor-help" tabindex="0" aria-expanded="false"><span
 class="screen-reader-text">Help</span></button>
                         </div>
                         <# if ( data.description ) { #>
                                 <div class="description customize-panel-
 description">
                                         {{{ data.description }}}
                                 </div>
                         <# } #>
                 </li>
                                 </script>
                 <script type="text/html" id="tmpl-customize-panel-
 default">
                                         <li id="accordion-panel-{{ data.id
 }}" class="accordion-section control-section control-panel control-
 panel-{{ data.type }}">
                         <h3 class="accordion-section-title" tabindex="0">
                                 {{ data.title }}
                                 <span class="screen-reader-text">Press
 return or enter to open this panel</span>
                         </h3>
                         <ul class="accordion-sub-container control-panel-
 content"></ul>
                 </li>
                                 </script>
         ' contains "accordion-section-content".

 /srv/www/wp-develop/svn/tests/phpunit/tests/customize/panel.php:192

 FAILURES!
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30737#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform