[wp-trac] [WordPress Trac] #32531: Media library filename based on GUID prevents embedding

[WordPress Trac]

#32531: Media library filename based on GUID prevents embedding
--------------------------------+-----------------------------
 Reporter:  daxelrod            |      Owner:
     Type:  defect (bug)        |     Status:  new
 Priority:  normal              |  Milestone:  Awaiting Review
Component:  Media               |    Version:  4.1
 Severity:  normal              |   Keywords:
  Focuses:  ui, administration  |
--------------------------------+-----------------------------
 The "Add Media" modal on posts is dependent on GUID matching the actual
 filename to allow embedding of audio and video media attachments. The
 "Attachment Display Settings" pane provides options for "Embed or Link" or
 "Link To" depending on {{{canEmbed}}}. But if the GUID is a permalink
 (example.com/?attachment_id=XXX) instead of an actual filepath
 (example.com/wp-content/wp-uploads/file.mp3), the audio or media element
 cannot be embedded in a post via the admin UI - only the "Link To" options
 will be presented.

 {{{wp.media.controller.Library.canEmbed}}} checks for attachment type
 "audio" or "video" and also checks the filename for a specific extension:

 {{{
 return _.contains( wp.media.view.settings.embedExts,
 attachment.get('filename').split('.').pop() );
 }}}

 If given an actual filename, the function performs as expected. But
 provided with a permalink, it fails and the attachment cannot be embedded.

 Imported media especially has this issue because of how GUIDs are
 automatically assigned in {{{wp_insert_post()}}}:

 {{{
         // Set GUID.
         if ( ! $update && '' == $current_guid ) {
                 $wpdb->update( $wpdb->posts, array( 'guid' =>
 get_permalink( $post_ID ) ), $where );
         }
 }}}

 Fixing this has a side benefit of making the attachment title (filename)
 in the media library more accurate as well.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32531>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform