[wp-trac] [WordPress Trac] #32508: Action Hooks for empty username and empty password

WordPress Trac noreply at wordpress.org
Thu May 28 14:53:35 UTC 2015


#32508: Action Hooks for empty username and empty password
-------------------------+------------------------------
 Reporter:  jwarren      |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Plugins      |     Version:  trunk
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+------------------------------
Changes (by MikeHansenMe):

 * keywords:   => has-patch


Comment:

 I looked into this a bit more and it seems the code that prevents
 'wp_login_failed' was added intentionally.
 [https://github.com/WordPress/WordPress/commit/3f22da5123f214ddf4ca9fc73b99cdcc5474269e]

 Prior to that commit it did trigger on all failures. I asked Ryan about it
 and he said he thought it was to differentiate between authentication
 errors and user input errors.

 I think by passing in the error code we are still covering that however
 there is the concern that it is a change in behavior. It was also a change
 in behavior when that commit was made.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32508#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list