[wp-trac] [WordPress Trac] #5305: permalinks broken when article name is numeric

[WordPress Trac]

#5305: permalinks broken when article name is numeric
--------------------------+---------------------------
 Reporter:  thomask       |       Owner:  valendesigns
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.3
Component:  Permalinks    |     Version:  2.3.1
 Severity:  major         |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+---------------------------

Comment (by boonebgorges):

 Back to the drawing board with [attachment:5305.16.diff]. I've moved the
 check into `wp_unique_post_slug()`. This avoids weird issues with post
 drafts, and more closely parallels the similar pagination checks in
 [13424].

 16.diff does not contain the rewrite/query parsing. I'm of two minds about
 this. On the one hand, forcing uniqueness in `wp_unique_post_slug()` means
 that slug conflicts won't happen under normal circumstances, so it's not
 worth the additional overhead that `wp_resolve_numeric_slug_conflicts()`
 introduces. On the other hand, post/archive URL conflicts may still arise
 in the following cases: (a) legacy content, (b) changed permalink
 settings, (c) manual manipulation (direct SQL, filtering
 `'wp_unique_post_slug'`, etc). I could go either way here. valendesigns,
 what do you think?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/5305#comment:86>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform