[wp-trac] [WordPress Trac] #31334: Customizer JS API should handle container removal from document
WordPress Trac
noreply at wordpress.org
Tue May 26 03:49:45 UTC 2015
#31334: Customizer JS API should handle container removal from document
-------------------------+-----------------------------------------
Reporter: Aniruddh | Owner: westonruter
Type: enhancement | Status: assigned
Priority: normal | Milestone: 4.3
Component: Customize | Version: 4.1
Severity: normal | Resolution:
Keywords: has-patch | Focuses: javascript, administration
-------------------------+-----------------------------------------
Comment (by westonruter):
Yes, this makes sense. However, I think the logic shouldn't be added to
the base class's method `wp.customize.Values.prototype.remove()` since
there's nothing about `container` mentioned at all in `customize-
base.js`.. Instead, this should be added in the subclasses that actually
have this property. And then `customize-widgets.js` can also take
advantage of this to remove its own `control.container.remove()`. See
[attachment:31334.2.diff] for what I have in mind.
Needs QUnit testing.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/31334#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list