[wp-trac] [WordPress Trac] #32435: error messages returned by auth modal when trying to update a plugin lack detail

[WordPress Trac]

#32435: error messages returned by auth modal when trying to update a plugin lack
detail
-----------------------------+-----------------------------
 Reporter:  TerraFrost       |      Owner:
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  Upgrade/Install  |    Version:
 Severity:  normal           |   Keywords:
  Focuses:                   |
-----------------------------+-----------------------------
 If you try to update a plugin and encounter an error via the auth modal
 you'll get a generic "Unable to connect to the filesystem. Please confirm
 your credentials." instead of a more detailed and more helpful error
 message like any of the ones wp-admin/includes/class-wp-filesystem-
 ssh2.php actually generates. eg.

 * Failed to connect to SSH2 Server %1$s:%2$s
 * Username/Password incorrect for %s
 * Public and Private keys incorrect for %s

 This is because the bulk_upgrader method in wp-admin/includes/class-wp-
 upgrader.php returns a false rather than the actual error. Two other
 changes need to be made for it to work as detailed in the attached patch.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32435>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform