[wp-trac] [WordPress Trac] #3670: Removing CDATA close tag ( ]]> ) unbalances the CDATA block

WordPress Trac noreply at wordpress.org
Sun May 17 18:22:15 UTC 2015


#3670: Removing CDATA close tag ( ]]> ) unbalances the CDATA block
----------------------------------------+-----------------------------
 Reporter:  scenic                      |       Owner:  andy
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  Future Release
Component:  Posts, Post Types           |     Version:  2.1
 Severity:  minor                       |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:  template
----------------------------------------+-----------------------------

Comment (by stevenkword):

 @jorbin I hate to see this be such a prolonged pain point for so many
 people.  There appear to be two proposed ways forward that has caused the
 ticket to repeatedly stall.

 1.) Hook the `str_replace` functionality by a filter
 2.) Properly escape/concatenate CDATA blocks for inclusion in XML

 I think there are merits to both approaches.  The first solution has
 little risk and provides developers to properly work around the issues
 they are having in core.  However, it has been pointed out that hooking in
 the problematic function doesn't solve the bigger picture perfectly.  The
 second solution appears to be what we would like tackle, but not without
 thorough testing.  It is a much bigger lift.

 I propose we address this ticket with the filter approach from 3670.2.diff
 as to put a nail in the coffin of requiring plugin authors to hack at
 core.  I'd then like to open a new ticket aimed at tackling the root of
 the problem as it relates to the way we escape XML.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/3670#comment:90>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list