[wp-trac] [WordPress Trac] #16956: Comments Being Pulled from Non-Existent Post Types
WordPress Trac
noreply at wordpress.org
Wed May 13 13:42:24 UTC 2015
#16956: Comments Being Pulled from Non-Existent Post Types
-----------------------------------+------------------
Reporter: sterlo | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.3
Component: Posts, Post Types | Version: 3.1
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion | Focuses:
-----------------------------------+------------------
Changes (by boonebgorges):
* keywords: has-patch commit 4.1-early => has-patch 2nd-opinion
* milestone: Future Release => 4.3
Comment:
Circling back around to this. Forcing `'do_not_allow'` in these cases
seems problematic, as it means that even administrators will not be able
to manage the content in question. As suggested by nacin on #13905
https://core.trac.wordpress.org/ticket/13905#comment:10, it seems safer to
fall back on some sane defaults. [attachment:16956.5.diff] accomplishes
this by falling back on `get_post_type_object( 'post' )`. This seems
pretty safe to me, but a second opinion would be helpful.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/16956#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list