[wp-trac] [WordPress Trac] #32354: is_ssl() does not work on cloud hosting

[WordPress Trac]

#32354: is_ssl() does not work on cloud hosting
--------------------------------------------------+------------------------
 Reporter:  mdawart                               |       Owner:  chriscct7
     Type:  defect (bug)                          |      Status:  closed
 Priority:  normal                                |   Milestone:
Component:  General                               |     Version:  4.1
 Severity:  normal                                |  Resolution:  duplicate
 Keywords:  dev-feedback has-patch needs-testing  |     Focuses:
--------------------------------------------------+------------------------
Changes (by dd32):

 * keywords:  dev-feedback has-patch needs-testing needs-nacin => dev-
     feedback has-patch needs-testing
 * resolution:   => duplicate
 * status:  accepted => closed
 * component:  Permalinks => General
 * milestone:  4.3 =>


Comment:

 Duplicate of #31288.

 I don't believe we can trust the `HTTP_X_FORWARDED_PROTO` variable, as
 clients can set it, bypassing any checks which rely upon `is_ssl()`.

 The correct method is to either
 a) Fix the server variables in the server to reflect the upstream proxy
 b) Fix the server variables in wp-config.php to reflect the upstream proxy

 You can see my full reasoning here:
 https://core.trac.wordpress.org/ticket/31288#comment:11

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32354#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform