[wp-trac] [WordPress Trac] #31939: paginate_links() - incorrect links on return to the first page

WordPress Trac noreply at wordpress.org
Thu May 7 10:05:20 UTC 2015


#31939: paginate_links() - incorrect links on return to the first page
-------------------------------------+---------------------------
 Reporter:  bobbingwide              |       Owner:  boonebgorges
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  4.3
Component:  Themes                   |     Version:  4.1.1
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------------
Changes (by bobbingwide):

 * keywords:  has-patch, needs-testing => has-patch needs-testing


Comment:

 Sorry I didn't get a chance to provide feedback on the code before it was
 committed, but I had to adjust my workaround because of the latest
 security scare etc..

 The comment I did want to make was that for performance the test on total
 pages should be a lot earlier.
 Shall I raise a separate TRAC for this?


 {{{
 // Who knows what else people pass in $args
         $total = (int) $args['total'];
         if ( $total < 2 ) {
                 return;
         }
 }}}

 And maybe remove the one line comment too?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31939#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list