[wp-trac] [WordPress Trac] #32224: delete_post_meta() not working as expected when $meta_value is specified as 0 or '0'

WordPress Trac noreply at wordpress.org
Fri May 1 14:57:47 UTC 2015


#32224: delete_post_meta() not working as expected when $meta_value is specified as
0 or '0'
--------------------------------+---------------------------
 Reporter:  husobj              |       Owner:  boonebgorges
     Type:  defect (bug)        |      Status:  reviewing
 Priority:  normal              |   Milestone:  4.3
Component:  Options, Meta APIs  |     Version:  4.2.1
 Severity:  normal              |  Resolution:
 Keywords:                      |     Focuses:
--------------------------------+---------------------------

Comment (by sc0ttkclark):

 delete_metadata uses this:


 {{{
 if ( $meta_value )
     $query .= $wpdb->prepare(" AND meta_value = %s", $meta_value );
 }}}

 It should probably be:

 {{{
 if ( '' !== $meta_value && null !== $meta_value )
     $query .= $wpdb->prepare(" AND meta_value = %s", $meta_value );
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32224#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list