[wp-trac] [WordPress Trac] #27863: Move $content_width inside setup function in core-bundled Themes

WordPress Trac noreply at wordpress.org
Fri May 1 11:45:13 UTC 2015


#27863: Move $content_width inside setup function in core-bundled Themes
------------------------------------------+-----------------------------
 Reporter:  chipbennett                   |       Owner:
     Type:  enhancement                   |      Status:  new
 Priority:  normal                        |   Milestone:  Future Release
Component:  Bundled Theme                 |     Version:  3.9
 Severity:  normal                        |  Resolution:
 Keywords:  has-patch dev-feedback close  |     Focuses:
------------------------------------------+-----------------------------

Comment (by chipbennett):

 Replying to [comment:9 jorbin]:
 > Sorry that I didn't really articulate my rational Chip. My bad.
 >
 > What if a child theme has over riden `twentyten_setup` et al. (since
 they are pluggable function) without defining `$content_width`? If we make
 this change, those themes will no longer be defining `$content_width`.

 Thanks, @jorbin. That's a fair concern. What if, instead of putting it in
 the setup function, it were inside its own callback?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27863#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list