[wp-trac] [WordPress Trac] #29699: add_theme_support( 'screen-reader-text' );

[WordPress Trac]

#29699: add_theme_support( 'screen-reader-text' );
-------------------------+----------------------------
 Reporter:  GaryJ        |       Owner:
     Type:  enhancement  |      Status:  reopened
 Priority:  normal       |   Milestone:
Component:  Themes       |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  accessibility
-------------------------+----------------------------
Changes (by Otto42):

 * status:  closed => reopened
 * resolution:  wontfix =>


Comment:

 This needs another look at it.

 Core just broke backward compatibility with .screen-reader-text in
 [31821]. Okay, yeah, it's *really* minor, but for anybody running a theme
 without a .screen-reader-text rule, then now new text appears where it did
 not appear before.

 I don't think we need add_theme_support. I think we need output of the
 proper rules, by default, without any opt-out. All the twenty-themes have
 the same basic set of .screen-reader-text rules. Are those rules not
 universally applicable for "hiding things"?

 It seems to me that .screen-reader-text's whole goal is to hide things in
 an accessible way. Which is fair, but is it really the problem of the
 theme? Is there any case in which this set of rules Joe provides needs to
 be altered by a theme in some way?
 https://make.wordpress.org/accessibility/2015/02/09/hiding-text-for-
 screen-readers-with-wordpress-core/

 Should we not be including some default set of rules for backward
 compatibility? It could be as simple as a single line of CSS in wp_head.
 Requiring themes to do this for forward compat and customization is fine,
 but by not making some form of back-compat, we're putting core in the
 future position of adding a bunch of new text to people's sites that they
 might not want to display, and might not be expecting. Comments popup link
 is just the first, really.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29699#comment:36>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform