[wp-trac] [WordPress Trac] #31233: Dismissable admin notices

[WordPress Trac]

#31233: Dismissable admin notices
----------------------------+--------------------------------
 Reporter:  ryan            |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  4.2
Component:  Administration  |     Version:  4.1
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  ui, accessibility
----------------------------+--------------------------------

Comment (by valendesigns):

 Patch [attachment:31233.21.diff] is ready for testing.

 Replying to [comment:44 helen]:
 > Let's use a class of `.is-dismissible` and target `.notice.is-
 dismissible` in JS as well as the one CSS rule. `.is-dissmisible` itself
 should likely never have any CSS defined.

 I've switched to `.is-dismissible`.

 > If we are inserting the button with JS after all, do we really need to
 put it in PHP for the edit screen notice? I think it's fine to add it with
 JS and just add the class in PHP.

 I've reverted back to having the JS insert the button for now. We can
 always add it to the PHP later.

 > Should we remove the notice from the DOM once it's hidden?

 I don't think it would hurt and have added it back to the JS.

 > Is removing the `.updated` class going to affect anything that's
 assuming that class (plugins/themes doing JS targeting)? Not a blocker,
 but I don't like to cause breakage without knowing about it first.

 I don't know if there is an actual concern here. However, so we can move
 forward without worrying I've made it so the `.updated` class is still
 there for backwards compatibility and added the new classes in addition to
 it so we can use `.notice` as the parent target.

 > That Opera hack makes me pretty unhappy to see - which versions of Opera
 are we talking about? If it's an absolute must, it needs to be commented.

 The issue is in Opera 12.16 but I've removed that code and reworked the
 CSS slightly so that IE is still supported. Opera is the only browser that
 looks off. It's shifted up by 3-4 pixels. However, most of the other font
 icons are off so I guess this is acceptable behavior?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31233#comment:47>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform