[wp-trac] [WordPress Trac] #31233: Dismissable admin notices

[WordPress Trac]

#31233: Dismissable admin notices
----------------------------+--------------------------------
 Reporter:  ryan            |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  4.2
Component:  Administration  |     Version:  4.1
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  ui, accessibility
----------------------------+--------------------------------
Changes (by helen):

 * keywords:  has-patch dev-feedback commit => has-patch


Comment:

 Some thoughts:

 * Let's use a class of `.is-dismissible` and target `.notice.is-
 dismissible` in JS as well as the one CSS rule. `.is-dissmisible` itself
 should likely never have any CSS defined.
 * If we are inserting the button with JS after all, do we really need to
 put it in PHP for the edit screen notice? I think it's fine to add it with
 JS and just add the class in PHP.
 * I am not too worried about things just jumping up, given that I think
 your visual focus would be on the notice. Have not yet tested the
 animation, though, so we will see how that feels.
 * Should we remove the notice from the DOM once it's hidden?
 * Is removing the `.updated` class going to affect anything that's
 assuming that class (plugins/themes doing JS targeting)? Not a blocker,
 but I don't like to cause breakage without knowing about it first.
 * That Opera hack makes me pretty unhappy to see - which versions of Opera
 are we talking about? If it's an absolute must, it needs to be commented.
 * All CSS selectors on separate lines, please - if we're touching a line
 that breaks that rule, then we can fix it here.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31233#comment:44>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform