[wp-trac] [WordPress Trac] #26600: Search installed themes input has no submit button

[WordPress Trac]

#26600: Search installed themes input has no submit button
----------------------------------+----------------------------------------
 Reporter:  grahamarmfield        |       Owner:  SergeyBiryukov
     Type:  defect (bug)          |      Status:  reviewing
 Priority:  normal                |   Milestone:  4.2
Component:  Themes                |     Version:  3.8
 Severity:  normal                |  Resolution:
 Keywords:  has-patch dev-        |     Focuses:  accessibility, javascript
  feedback                        |
----------------------------------+----------------------------------------

Comment (by adamsilverstein):

 I thought InstallerSearch already had a debounce, I will double check.

 yea, _.debounce is awesome and perfect for this use!

 Replying to [comment:40 afercia]:
 > Thanks @adamsilverstein :) now I understand how `_.debounce` works, I
 assumed it was just a "fixed" delay. If I'm not wrong, your latest patch
 adds it just in the installed theme search, we should do the same for
 `themes.view.InstallerSearch`. I'd recommend to increase 250ms to 500ms,
 same value used in wplink.
 >
 > Also, maybe we should exclude some keys, i.e. arrows, "home", "end"?
 though he POST is not sent when the search term is unchanged, all the
 functions there will run also when pressing arrows. Or maybe filter only
 alphanumeric keys?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26600#comment:44>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform