[wp-trac] [WordPress Trac] #31233: Dismissable admin notices

[WordPress Trac]

#31233: Dismissable admin notices
-------------------------------------------+-------------------------------
 Reporter:  ryan                           |       Owner:
     Type:  task (blessed)                 |      Status:  new
 Priority:  normal                         |   Milestone:  4.2
Component:  Administration                 |     Version:  4.1
 Severity:  normal                         |  Resolution:
 Keywords:  has-patch dev-feedback commit  |     Focuses:  ui,
                                           |  accessibility
-------------------------------------------+-------------------------------

Comment (by afercia):

 Replying to [comment:41 DrewAPicture]:
 > the focus outline gets cut off while it's animating?
 `slideUp()` applies `overflow: hidden` on the element being animated, see
 screenshot:

 [[Image(https://cldup.com/GFwexXmrIZ.png)]]

 was not happening before because the dismiss button was a bit smaller:

 [[Image(https://cldup.com/g7HDM6hm1q.png)]]

 I'd say this is an opportunity to solve two issues at the same time: when
 the dismiss button is focused and you activate it with your keyboard,
 there's a focus loss.
 As far as I know, Firefox is the only browser that keeps focus "in place"
 but with all other browsers focus will fallback to the document and you
 will have to start tabbing from the beginning of the page.

 Simply moving the focus to a proper place when the dismiss button is
 activated would solve both issues. Would propose to move it to the main
 content div `#wpbody-content` which is focusable thanks to `tabindex=0`.

 Not for arguing, but please notice in the latest patch there are a couple
 of trailing spaces and one tab character to remove.

 Also I'm not sure `noindex:-o-prefocus` is really needed, @valendesigns
 could you please expand on that?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31233#comment:42>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform