[wp-trac] [WordPress Trac] #31798: Editor: switch undo and redo in RTL
WordPress Trac
noreply at wordpress.org
Sun Mar 29 12:10:56 UTC 2015
#31798: Editor: switch undo and redo in RTL
--------------------------+------------------
Reporter: yoavf | Owner:
Type: defect (bug) | Status: new
Priority: low | Milestone: 4.2
Component: Editor | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses: rtl
--------------------------+------------------
Comment (by yoavf):
Replying to [comment:1 ocean90]:
> Maybe we should extend our `swap-dashicons-left-right-arrows` rule with
these icons: [source:/trunk/Gruntfile.js at 31875#L196]
Oh nice, I never saw that beore (that's what I get for sitting out of dev
cycles).
Anyway, the regex in {{{swap-dashicons-left-right-arrows}}} expects the
values to be surrounded by double quotes, and we have (in this file, and
probably other) content values surrounded by single quotes.
Should we improve the regex to catch both, or do we have a guideline on
how to surround content values this way or another?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/31798#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list