[wp-trac] [WordPress Trac] #31233: Dismissable admin notices

[WordPress Trac]

#31233: Dismissable admin notices
-------------------------------------------+-------------------------------
 Reporter:  ryan                           |       Owner:
     Type:  task (blessed)                 |      Status:  new
 Priority:  normal                         |   Milestone:  4.2
Component:  Administration                 |     Version:  4.1
 Severity:  normal                         |  Resolution:
 Keywords:  has-patch dev-feedback commit  |     Focuses:  ui,
                                           |  accessibility
-------------------------------------------+-------------------------------

Comment (by afercia):

 Please consider to add focus style for the dismiss button. In the proposed
 refreshed patch:
 - added focus style
 - changed padding to horizontally center the icon
 - CSS fix for IE 8
 - reordered CSS properties, see [https://make.wordpress.org/core/handbook
 /coding-standards/css/#property-ordering CSS Property Ordering ]
 - all non-submit button should have a type attribute `type="button"`

 outstanding issues:
 - maybe "notice-dismissible" should be "notice-dismissable"?
 - color contrast ratio #bbb on #fff is too low, I'd say to iterate on this
 in #31713
 - just as a note: markup from `edit-form-advanced.php` will have white
 space between elements (new lines) while JS generated markup won't, this
 may cause issues with styling (when/if using inline-blocks)

 [[Image(https://cldup.com/t59FkbUHLx.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31233#comment:36>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform