[wp-trac] [WordPress Trac] #31782: Customizer: Use proper preview URL for Live Preview links

WordPress Trac noreply at wordpress.org
Sat Mar 28 05:22:34 UTC 2015

#31782: Customizer: Use proper preview URL for Live Preview links
 Reporter:  mattwiebe     |       Owner:  ocean90
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  4.2
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  javascript
Changes (by celloexpressions):

 * keywords:  has-patch commit => needs-patch
 * status:  closed => reopened
 * resolution:  fixed =>


 Sorry, totally missed this.

 This was done so that we can preserve `url` and `return` URL parameters,
 to make the experience smoother (I changed it from using
 `theme.actions.customize` for that reason). The page you're previewing
 shouldn't be changed when you switch themes, which currently works if you
 don't navigate further in the preview and will be improved westonruter's
 ticket that adds history and url updating for that.

 I'd suggest correcting the bug with assuming that the theme id can be used
 as the query arg by using either an additional available field or adding a
 field to `wp_prepare_themes_for_js()`. Unfortunately the way it currently
 works, we need to build the URL in PHP with the adding/removing query
 args, which shouldn't happen in prepare_themes_for_js.

Ticket URL: <https://core.trac.wordpress.org/ticket/31782#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list