[wp-trac] [WordPress Trac] #31596: TinyMCE test adjustments

[WordPress Trac]

#31596: TinyMCE test adjustments
--------------------------+-----------------------------
 Reporter:  iseulde       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  low           |   Milestone:  Future Release
Component:  TinyMCE       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+-----------------------------

Comment (by azaozz):

 > Load from src like the other tests

 We used to do that. However in some (rare) cases things can get broken
 during the build. I'd rather know that the concatenated, pre-compressed
 TinyMCE works properly :)

 If testing /src is so important, we can add another link for it.

 > Automatically add the plugins without overwriting files.

 Not sure about that. "Duck-punching" `tinymce.EditorManager` doesn't seem
 good :)

 > Don't run tests where no plugins are loaded. We're running these test
 just to test our plugins.

 We are running all TinyMCE tests with all of our plugins loaded. There are
 few tests where not all of TinyMCE is loaded. We can exclude these but...
 What's the benefit? Will have to edit more and more files just for saving
 few milliseconds of tests that are very rarely run? The opposite is true
 -- more maintenance, see below.

 > Remove everything we don't use.

 That's nice but will mean more and more maintenance. The TinyMCE tests are
 typically updated on every release. The more we deviate from the
 originals, the more maintenance will be needed.

 The easiest way to maintain edited files is when we include the whole file
 and comment out the parts we don's use. If we "scramble" the blocks/line
 numbers it gets much harder.

 Also the patch removes the (WordPress specific) Obsolete.js tests. That's
 not good, we've had many failures there in the past. Even if all the rest
 of the tests are removed, this one should stay.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31596#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform