[wp-trac] [WordPress Trac] #31608: Shiny Updates: fine-tune UI for filesystem credentials request modal

[WordPress Trac]

#31608: Shiny Updates: fine-tune UI for filesystem credentials request modal
-------------------------------------+-------------------------------------
 Reporter:  ericlewis                |       Owner:  ericlewis
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.2
Component:  Upgrade/Install          |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch ui-feedback    |     Focuses:  ui, accessibility,
  dev-feedback                       |  javascript
-------------------------------------+-------------------------------------

Comment (by jorbin):

 This is getting pretty close. A couple of changes that I made:

  -  On small windows (those with a height less than 480px which is the
 size of the window ), the modal is now fullscreen to be more usable.
 [[Image(https://cldup.com/OAmoX5eh_W.png)]]

  - Canceling now restores the original HTML instead of having
 "updating..." stay there

 More work remains on making sure that canceling doesn't block you from
 trying again.  Some flows that need to be refined and could use some more
 testing include:
  - Click Update, cancel, click update again
  - Click Update, enter bad credentials, cancel, click update again
  - Click Update, cancel, click update on a different plugin

 I think the error state modal (what comes back when a user has entered the
 wrong credentials) needs an a11y review.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31608#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform