[wp-trac] [WordPress Trac] #31742: Customizer: use attachment ID to show current header

WordPress Trac noreply at wordpress.org
Wed Mar 25 22:59:04 UTC 2015


#31742: Customizer: use attachment ID to show current header
--------------------------+------------------
 Reporter:  sirbrillig    |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.2
Component:  Customize     |     Version:  3.9
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------

Comment (by sirbrillig):

 I also just realized that this does not solve the issue of default images
 if the protocol or domain are different, and that presents something of a
 challenge.

 For example, on WordPress.com we use a CDN URL for the theme's default
 image (eg: `https://s0.wp.com/wp-
 content/themes/pub/twentythirteen/images/headers/circle.png`) which is on
 a different domain than the customizer is running on.

 In that case, these patches (and the code that's currently in trunk, for
 that matter) will still show "No image set" when the default image is set.
 I'm not sure the best way to handle that case. I have a patch that will
 deal with it by stripping the protocol and domain name from the default
 image, but I don't really think that's the right way.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31742#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list