[wp-trac] [WordPress Trac] #28687: Removing background image and/or reverting background color to default doesn't remove custom-background body class and remove theme mods

[WordPress Trac]

#28687: Removing background image and/or reverting background color to default
doesn't remove custom-background body class and remove theme mods
---------------------------+------------------------
 Reporter:  slobodanmanic  |       Owner:  obenland
     Type:  defect (bug)   |      Status:  reviewing
 Priority:  normal         |   Milestone:  4.2
Component:  Themes         |     Version:  3.9
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+------------------------

Comment (by obenland):

 Replying to [comment:16 ocean90]:
 > The patch needs to be checked against [21001].
 r21054 reverted parts of r21001, and [attachment:28687.5.diff] is coherent
 with the last sentence in that commit message:

 `[…] the custom-background class should not be shown when only a default
 color is in use.`

 The patch allows `.custom-background` only to be added if background color
 or image divert from their defaults.

 The question whether a theme mod should be removed if reset to its default
 value, could be material for another discussion or ticket. @ocean90 and I
 only [https://wordpress.slack.com/archives/core-
 customize/p1421790776000084 started talking about it].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28687#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform