[wp-trac] [WordPress Trac] #31656: Add menu ID argument to `wp_page_menu()` so that fallback menus have same attributes as `wp_nav_menu()`
WordPress Trac
noreply at wordpress.org
Wed Mar 25 18:39:25 UTC 2015
#31656: Add menu ID argument to `wp_page_menu()` so that fallback menus have same
attributes as `wp_nav_menu()`
-------------------------------------+-----------------------------
Reporter: lancewillett | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Menus | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-refresh | Focuses:
-------------------------------------+-----------------------------
Changes (by ocean90):
* keywords: has-patch => has-patch needs-refresh
* type: defect (bug) => enhancement
* milestone: 4.2 => Future Release
Comment:
I don't think that `sanitize_html_class()` is needed. This could lead to
regressions since it's possible to define multiple CSS classes. The id
attribute should be before the class attribute.
Also the current patch will print an empty id attribute by default. That
should be avoided.
Punting per bug scrub.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/31656#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list