[wp-trac] [WordPress Trac] #31608: Shiny Updates: fine-tune UI for filesystem credentials request modal

[WordPress Trac]

#31608: Shiny Updates: fine-tune UI for filesystem credentials request modal
-------------------------------------+-------------------------------------
 Reporter:  ericlewis                |       Owner:  ericlewis
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.2
Component:  Upgrade/Install          |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch ui-feedback    |     Focuses:  ui, accessibility,
  dev-feedback                       |  javascript
-------------------------------------+-------------------------------------

Comment (by ericlewis):

 Thanks for the help @afercia!

 In attachment:31608.3.diff, riffing off attachment:31608.3.patch:

 * Fix a bug that left/right keypress events triggered closing the modal.
 * Move object property definitions to the top of the file, group methods.
 * Simplify/combine logic for storing the jQuery element to return focus to
 after closing the request for credentials modal in
 `wp.updates.$elToReturnFocusToFromCredentialsModal`
 * Not head-over-heels for passing a jQuery event object into
 `wp.updates.requestFilesystemCredentials( e )`, but I'm on the fence about
 separating the logic requiring the event into its own method.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31608#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform