[wp-trac] [WordPress Trac] #31701: Emoji: Avoid enqueueing JS by default
WordPress Trac
noreply at wordpress.org
Tue Mar 24 10:25:37 UTC 2015
#31701: Emoji: Avoid enqueueing JS by default
------------------------------------+--------------------------------------
Reporter: obenland | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.2
Component: General | Version: trunk
Severity: major | Resolution:
Keywords: emoji has-patch commit | Focuses: javascript, performance
------------------------------------+--------------------------------------
Changes (by pento):
* keywords: emoji has-patch => emoji has-patch commit
Comment:
Nice one, @azaozz. :-)
[attachment:31701.11.diff] has a few small changes:
* Uncomments some code accidentally commented out
[attachment:31701.8.diff].
* Moves the `print_emoji_detection_script` hook back to `wp_head`, which
was accidentally changed back to `wp_print_scripts` in
[attachment:31701.9.diff].
* Removes the now unnecessary changes to unit tests, originally needed
because of `print_emoji_detection_script` being attached to
`wp_print_scripts`.
Unless anyone has any better filename suggestions, I'm pretty happy with
the state of this patch. Barring any objections, I'll commit it tomorrow.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/31701#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list