[wp-trac] [WordPress Trac] #31233: Dismissable admin notices
WordPress Trac
noreply at wordpress.org
Mon Mar 23 13:04:42 UTC 2015
#31233: Dismissable admin notices
-------------------------------------------+-------------------------------
Reporter: ryan | Owner:
Type: task (blessed) | Status: new
Priority: normal | Milestone: 4.2
Component: Administration | Version: 4.1
Severity: normal | Resolution:
Keywords: has-patch dev-feedback commit | Focuses: ui,
| accessibility
-------------------------------------------+-------------------------------
Comment (by paulwilde):
Using the class {{{.alert-dismiss}}}, or better yet {{{.alert-
dismissable}}} would be better as it gives it context and conforms more
with the classes which were introduced in [30505]. It also has the benefit
of not being too generic so you can easily search through the entire code-
base and know that all of the results refer to this functionality.
All of the {{{.updated}}} and {{{.error}}} classes should eventually be
updated to use the {{{.notice-*}}} classes inside the admin as well and
just keep the CSS there for back-compact. I'll create a patch (for 4.3, as
4.2 is too far into beta I'm guessing?) at some point which does just that
unless someone else wants to champion that.
Also another minor gripe, the classes used are overqualified they should
simply just be {{{.alert-close}}} instead of {{{div.close}}}. then the CSS
can be refactored to be {{{.alert-close}}} instead of {{{.wrap div.dismiss
button.close}}}.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/31233#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list