[wp-trac] [WordPress Trac] #31721: Theme switcher: "add new" button bug

WordPress Trac noreply at wordpress.org
Sun Mar 22 21:38:12 UTC 2015


#31721: Theme switcher: "add new" button bug
--------------------------------------+------------------------
 Reporter:  daniluk4000               |       Owner:  bilacoder
     Type:  defect (bug)              |      Status:  assigned
 Priority:  normal                    |   Milestone:  4.2
Component:  Customize                 |     Version:  trunk
 Severity:  minor                     |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:  ui
--------------------------------------+------------------------
Changes (by DrewAPicture):

 * keywords:  needs-patch good-first-bug => good-first-bug has-patch
 * owner:   => bilacoder
 * status:  new => assigned


Comment:

 Hi @bilacoder, thanks for the patch!

 In [attachment:31721.diff], we should probably more-closely target the
 elements for that specific Customizer control, as things like `.wrap h2`
 are used in many other places in the admin, not just the Customizer. The
 same goes for floating `#customize-controls a`, as that affects links in
 basically ''any'' Customizer control.

 Targeting `.customize-themes-panel` as the top-level element might be a
 better starting place.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31721#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list