[wp-trac] [WordPress Trac] #31203: Focus style for add-new-theme should match hover style

[WordPress Trac]

#31203: Focus style for add-new-theme should match hover style
------------------------------------+----------------------------
 Reporter:  celloexpressions        |       Owner:
     Type:  defect (bug)            |      Status:  reopened
 Priority:  normal                  |   Milestone:  4.2
Component:  Themes                  |     Version:  3.8
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  accessibility
------------------------------------+----------------------------

Comment (by afercia):

 Checked last patch, doesn't apply anymore and needs a refresh after the
 admin color changes in r31422.
 The focus style on "Add New Theme" works nicely, see screenshot below,
 removing the box-shadow also make sense, nice touch :)
 By the way, it's inside a `<div>` appended as last item in a `<ul>`.
 That's invalid code of course but I'm also concerned about semantics:
 entering the Theme customizer, screen reader users will hear, for example:
 >"Theme 16"
 (that's the info in the heading). But then the following list has 17
 items, screen readers will read out:
 > list with 17 items
 maybe a bit confusing, also if the purpose of that list is to... list :)
 the themes, then should contain just themes. So the "Add New Theme" div
 should preferably be outside the list and at that point maybe can be just
 a link, not sure a `<div>` is really needed.

 [[Image(https://cldup.com/Z-XO3Lyc2B.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31203#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform