[wp-trac] [WordPress Trac] #30266: wp_mail() can send emails with a blank 'From' address

[WordPress Trac]

#30266: wp_mail() can send emails with a blank 'From' address
--------------------------+---------------------------
 Reporter:  drtonyb       |       Owner:  valendesigns
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.2
Component:  Mail          |     Version:  4.0
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+---------------------------
Changes (by westi):

 * keywords:  has-patch commit => needs-patch


Comment:

 Replying to [comment:16 DrewAPicture]:
 > [attachment:30266.2.diff] looks good to me, and sends emails in the
 expected format. Unit tests pass. Moving for commit consideration.

 I'm unsure about a few things here:

 * I think the unit tests would be better without the preg_matches and
 testing the actually generated headers - using the regular expressions
 looks strange in a set of tests to me
 * I think that the change to add ```} elseif ( '' !== trim( $content ) )
 {``` should be commented so it is obvious why this is being done.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30266#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform