[wp-trac] [WordPress Trac] #31708: _wp_staticize_emoji_for_email doesn't check for defined key in $mail array.
WordPress Trac
noreply at wordpress.org
Fri Mar 20 12:19:48 UTC 2015
#31708: _wp_staticize_emoji_for_email doesn't check for defined key in $mail array.
--------------------------+-----------------------------
Reporter: nerrad | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Mail | Version: trunk
Severity: normal | Keywords:
Focuses: |
--------------------------+-----------------------------
I think this was added in 4.2 along with the emoji stuff (YAY for emoji!).
This function should really be checking for whether the `$mail['message']`
index in the $mail array exists because other wp_mail hooks may be
swapping out 'message' in favor of some other thing they are doing (in
which case yes they won't get the emoji's in the content). It just
prevents php notices from being thrown and breaking ajax requests using
wp_mail when WP_DEBUG is on. In encountered such notice breaking things
in my testing.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/31708>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list