[wp-trac] [WordPress Trac] #24146: Menu items with blank labels are removed on saving

[WordPress Trac]

#24146: Menu items with blank labels are removed on saving
--------------------------+-----------------------------
 Reporter:  rodrigo@…     |       Owner:  SergeyBiryukov
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  4.2
Component:  Menus         |     Version:  3.5.1
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+-----------------------------

Comment (by SergeyBiryukov):

 [attachment:24146.2.diff] fixes the notice and uses an existing string,
 but still doesn't look like a complete solution.

 As noted in comment:15, if you remove the label for a post type or
 category item, the change is not saved and the label is restored, making
 the first part of the patch irrelevant.

 Looks like [attachment:24146.patch] attempted solve this, but it no longer
 applies cleanly and seems to break the labels of existing menu items when
 those changes are recreated manually. Also need to take [24560] into
 account.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/24146#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform