[wp-trac] [WordPress Trac] #31233: Dismissable admin notices
WordPress Trac
noreply at wordpress.org
Wed Mar 18 06:25:34 UTC 2015
#31233: Dismissable admin notices
----------------------------------------------+----------------------------
Reporter: ryan | Owner:
Type: task (blessed) | Status: new
Priority: normal | Milestone: 4.2
Component: Administration | Version: 4.1
Severity: normal | Resolution:
Keywords: make-flow has-patch dev-feedback | Focuses: ui,
| accessibility
----------------------------------------------+----------------------------
Comment (by valendesigns):
@adamsilverstein Thank you for the patch, though you probably should have
tested that it worked because there are JS errors in it. As well, the
event was correct the way I had it. You moved the namespace `wp-dismiss-
notice` into the selector, which would also have made it not work.
I added a bit more specificity to the JS by adding `.wrap` in patch
[attachment:31233.8.diff] and included your whitespace.
The CSS class name `.dismiss` is already used in other places throughout
the Core. I'm not against changing it, but would like to hear what others
have to say on the subject.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/31233#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list