[wp-trac] [WordPress Trac] #26646: On Appearance themes page ".themes" div is not covering floated elements.

[WordPress Trac]

#26646: On Appearance themes page ".themes" div is not covering floated elements.
--------------------------+---------------------------------
 Reporter:  5um17         |       Owner:  obenland
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  4.2
Component:  Themes        |     Version:  3.8
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  ui, administration
--------------------------+---------------------------------

Comment (by afercia):

 Please consider `overflow: hidden` will cut-off few pixels of the focus
 style box-shadows, see screenshot:

 [[Image(https://cldup.com/3q20tzKt8N.png)]]

 Would propose to introduce a new rule in `common.css`, to use where
 appropriate:
 {{{
 .contain-floats:after {
         content: '';
         display: table;
         clear: both;
 }
 }}}

 For reference: what `overflow: hidden` does to contain floats? It
 establishes a new ''block formatting context'',
 [http://www.w3.org/TR/CSS21/visuren.html#block-formatting see the CSS
 specs for a definition].

 There are also other ways to create a new block formatting context, but
 then you will have to play with widths, which is not always desirable. For
 example:
 {{{
 display: table-cell;
 width: 100%;
 }}}

 {{{
 display: inline-block;
 width: 100%;
 }}}

 `display: table;` will work too not because it establishes a block
 formatting contexts but because it generates an anonymous box with
 display: table-cell.

 Similar issue in #29897.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26646#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform