[wp-trac] [WordPress Trac] #31528: Shiny Updates: FTP Support

[WordPress Trac]

#31528: Shiny Updates: FTP Support
-------------------------------------+-------------------------------------
 Reporter:  pento                    |       Owner:  ericlewis
     Type:  task (blessed)           |      Status:  reopened
 Priority:  normal                   |   Milestone:  4.2
Component:  Upgrade/Install          |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  shiny-updates has-patch  |     Focuses:  ui, javascript,
  commit                             |  administration
-------------------------------------+-------------------------------------

Comment (by jorbin):

 Summarizing some conversation in slack today:

 Helen greped through the plugins and found a couple of plugins using the
 filter @jipmoore pointed out.  I looked at all of them and this is what I
 found:


 plugins/appcastlenet-api/
 plugins/iremotewp/
 plugins/wpcommand/
 plugins/wpremote/

 - It looks like they have the ability to override the credentials with
 something stored on the remote servers.  All four are using essentiallyy
 the same code. This has no affect on things from what I can tell. I've
 asked Human Made about the wpremote version. https://github.com/humanmade
 /WP-Remote-WordPress-
 Plugin/commit/ce7fe2fdbe111cf719b501421239d8f36d3aba97#commitcomment-10221682

 plugins/jetpack/

 - jetpack is bypassing credential checks for it's check to see if plugins
 need to be updated.  Should have no impact on ssh.

 plugins/site-manager

 - May cause an issue if direct isn't working.  I'll ping Marko who is an
 author of this plugin.

 plugins/ssh-sftp-updater-support/

 - Appears fine. It is modifying the form a bit. Will also ping plugin
 author once this lands asking that they make sure to test with beta.


 I also tested having the filter return true when it shouldn't and the
 experience with shiny updates is the same as without shiny updates (aka,
 broken).  This would absolutely appear to be an issue with a plugin and
 not one we need to worry about.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31528#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform