[wp-trac] [WordPress Trac] #31657: Press This: Firefox redirects parent page to a return value of true when pressing

[WordPress Trac]

#31657: Press This: Firefox redirects parent page to a return value of true when
pressing
--------------------------+-------------------------
 Reporter:  DrewAPicture  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.2
Component:  Press This    |     Version:  trunk
 Severity:  major         |  Resolution:
 Keywords:  needs-patch   |     Focuses:  javascript
--------------------------+-------------------------

Comment (by stephdau):

 The grunt task to uglify the bookmarklet is a special one, and uses
 `negate_iife: false` to cope with Firefox.

 Because of this, we ignore `wp-admin/js/bookmarklet.js` in the `core`
 uglification task.
 But that means that this task still finds the committed `wp-
 admin/js/bookmarklet.min.js` and (re-)uglifies it, but without
 `negate_iife: false`, therefore leading to having the issue with Firefox,
 specifically with the `build` branch (and releases), vs the bookmarklet
 working fine with the `src` branch.

 Attached patch fixes that issue by wildcarding `wp-
 admin/js/bookmarklet.*`, hence ignoring both the un-uglified and pre-
 uglified versions.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31657#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform