[wp-trac] [WordPress Trac] #31654: List tables: Select All shouldn't be a column header
WordPress Trac
noreply at wordpress.org
Mon Mar 16 18:21:25 UTC 2015
#31654: List tables: Select All shouldn't be a column header
----------------------------+--------------------------------
Reporter: afercia | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Administration | Version: 4.1
Severity: normal | Resolution:
Keywords: has-patch | Focuses: ui, accessibility
----------------------------+--------------------------------
Comment (by jdgrimes):
Just noticed a small issue in [attachment:31654.patch].
This line:
{{{
echo "<$th_or_td $id $class $style>$column_display_name</th>";
}}}
The closing tag is always a `th`, should be changed to a `td` when needed.
You can't just use `$th_or_td` though, because it will be `th scope="col"`
instead of just `th`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/31654#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list