[wp-trac] [WordPress Trac] #31328: Emoji in a slug fails to display

[WordPress Trac]

#31328: Emoji in a slug fails to display
------------------------------+-----------------------------
 Reporter:  kraftbj           |       Owner:  pento
     Type:  defect (bug)      |      Status:  reopened
 Priority:  normal            |   Milestone:  4.2
Component:  Formatting        |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  administration
------------------------------+-----------------------------

Comment (by boonebgorges):

 Replying to [comment:18 SergeyBiryukov]:
 > Replying to [comment:9 boonebgorges]:
 > > Those tests fail by design. The idea is that you should not be able to
 create terms with the same 'name' in the same taxonomy. That's what #17689
 is all about.
 >
 > Right, but only if no slug was provided. It should still be possible to
 create terms with the same name in the same taxonomy with different slugs,
 as noted by @Chouby. Looks like [31734] broke that.

 Yes, and in fact I thought I'd left a comment on this ticket yesterday to
 this very effect, but it looks like I forgot to press submit :)

 See [attachment:31328.6.diff]. This change should continue to preserve the
 spirit of the fix in #17689. I'm not 100% sure that it also preserves the
 fixes necessary for this ticket - pento, can you chime in here - but the
 unit tests continue to pass. (You'll see that 6.diff includes new unit
 tests that replace some older, less specific ones.)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31328#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform