[wp-trac] [WordPress Trac] #31616: Splitting request_filesystem_credentials into separate functions

[WordPress Trac]

#31616: Splitting request_filesystem_credentials into separate functions
---------------------------------------+------------------
 Reporter:  jipmoors                   |       Owner:
     Type:  enhancement                |      Status:  new
 Priority:  normal                     |   Milestone:  4.2
Component:  Filesystem API             |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  shiny-updates needs-patch  |     Focuses:
---------------------------------------+------------------

Comment (by jipmoors):

 '''request_filesystem_credentials filter'''
 In what way is this filter used and how do we maintain expected
 functionality?

 Currently `usable_filesystem_credentials` expects and array with a certain
 formatting depending on the `connection_type`.
 Would it be necessary to add a filter to that function to override the
 check to comply with 'custom' implementation (however that may look).

 '''changes'''
 With the `request_filesystem_credentials` functionality, if the filter
 returns something the entire function is skipped. When the new
 functionality is implemented, that will not exit on data but tries to
 validate the formatting of that data. There is no way to know where the
 credentials are coming from.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31616#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform