[wp-trac] [WordPress Trac] #31616: Splitting request_filesystem_credentials into separate functions

[WordPress Trac]

#31616: Splitting request_filesystem_credentials into separate functions
---------------------------------------+------------------
 Reporter:  jipmoors                   |       Owner:
     Type:  enhancement                |      Status:  new
 Priority:  normal                     |   Milestone:  4.2
Component:  Filesystem API             |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  shiny-updates needs-patch  |     Focuses:
---------------------------------------+------------------

Comment (by jipmoors):

 One note on the `usable_filesystem_credentials` that is a bit counter
 intuitive.

 The `$type` parameter is only used to check for 'direct' method when not
 supplied.
 If it's supplied it is not used, because the
 `$credentials['connection_type']` is being checked. This is what will be
 used on the form and is being used to connect eventually.

 Therefore my previous use case is not reflecting how it really works.

 Backwards compatibility dictates that the `$type` parameter should be
 there, a clearer documentation is needed to avoid unexpected results.

 Will provide addition documentation in patch.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31616#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform