[wp-trac] [WordPress Trac] #31233: Dismissable admin notices

[WordPress Trac]

#31233: Dismissable admin notices
----------------------------------------------+------------------
 Reporter:  ryan                              |       Owner:
     Type:  task (blessed)                    |      Status:  new
 Priority:  normal                            |   Milestone:  4.2
Component:  Administration                    |     Version:  4.1
 Severity:  normal                            |  Resolution:
 Keywords:  make-flow has-patch dev-feedback  |     Focuses:  ui
----------------------------------------------+------------------

Comment (by helen):

 Replying to [comment:13 valendesigns]:
 > The last patch had a minor UI issue where it would cover a bit of text
 in long messages.

 Wasn't meant to be a tested patch, I just dump work as patches onto
 tickets sometimes because I have a bash script that uploads them directly
 :) If it's a viable patch, I'll explain it in a comment. I decided the
 method wasn't viable for a couple of reasons, including UI, but wanted the
 record of "this was tried".

 > Once I fixed that, I saw a potential for making the whole thing much
 better. My implementation in patch [attachment:31233.2.diff] includes
 hide, but also adds dismiss with cookie support.

 It is super cool that you've done this, and being able to actually dismiss
 them would definitely be a longer term goal. For 4.2, that cannot happen
 now that we're in beta as that falls squarely into enhancement territory.
 Let's hold on to your patch, though, for sure.

 The reason why I want to be able to "hide" notices for this release is
 because #23367 went in, so I think it's a reasonable feature extension to
 be able to hide notices that are not going to show up again when you
 reload the page or navigate elsewhere, given the bad UI it causes on post
 edit. That's another big reason the earlier approach of JS insertion isn't
 a good one right now - we should only do these for core notices/messages
 in 4.2, and so we can do it in PHP. Maybe we only do it for post edit
 messages this release, even. To that end, I think we can go with an X icon
 (with screen reader text), at least.

 And finally, let's not forget that notices are moved with JS which is
 terrible (see [https://core.trac.wordpress.org/ticket/30885#comment:6 this
 comment on #30885]. If we're prepared to go down this road of persistently
 dismissable notices for all, we should probably think about making adding
 notices a little less of a manual process - see #12738 (wontfixed right
 now, but we can always change our minds).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31233#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform