[wp-trac] [WordPress Trac] #30577: Allow plugins to bypass wp_options when saving transients
WordPress Trac
noreply at wordpress.org
Fri Mar 13 08:10:59 UTC 2015
#30577: Allow plugins to bypass wp_options when saving transients
-------------------------------------------------+-------------------------
Reporter: mgibbs189 | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future
Component: Options, Meta APIs | Release
Severity: normal | Version: 2.8
Keywords: has-patch commit 4.2-early dev- | Resolution:
feedback | Focuses:
-------------------------------------------------+-------------------------
Comment (by jipmoors):
First of all, could you make the diff file from the trunk next time?
Perhaps adding the ticket number in front would be a good addition for
clearity.
I suggest to move the filter to after the `wp_using_ext_object_cache()` so
hooks won't get the wrong idea that they can manipulate stuff that is
ignored later on.
On the naming of the filter, I think it would be adding to the clearity if
it represented more of what it's doing, 'allow_set_transient_to_options'.
Setting 'result' to `true` does not reflect what the code is doing, I can
imagine that not calling the actions on a success could result in unwanted
behaviour but it sounds like the proper thing to do when you bypass saving
the value. Would appreciate 2nd opinion on this.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/30577#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list