[wp-trac] [WordPress Trac] #31528: Shiny Updates: FTP Support

[WordPress Trac]

#31528: Shiny Updates: FTP Support
-------------------------------------+-------------------------------------
 Reporter:  pento                    |       Owner:  ericlewis
     Type:  task (blessed)           |      Status:  reopened
 Priority:  normal                   |   Milestone:  4.2
Component:  Upgrade/Install          |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  shiny-updates needs-     |     Focuses:  ui, javascript,
  patch                              |  administration
-------------------------------------+-------------------------------------

Comment (by ericlewis):

 In attachment:31528.11.diff, a continuation of @jorbin's work in
 attachment:31528.10.diff.

 * Set `wp.updates.shouldRequestFilesystemCredentials` on document.ready;
 any earlier the element `#request-filesystem-credentials-dialog`
 definitely won't exist.
 * Change `wp.updates.shouldRequestFilesystemCredentials` conditionals to
 basic truthiness, since we're setting it to `true` or `false` now. This
 avoids some rampant plugin update/install requests.
 * Remove `wp.updates.updateAlways`. This also creates rampant request
 attempts because when every request comes back, it runs the first update
 on the queue. If an update is failing because of bad filesystem
 credentials, the lock should actually be kept and the queue not invoked.
 The queue will be invoked when the user submits the credentials form. For
 successful updates, remove the lock and hit the queue at the end of the
 success callback.
 * Spell out docs `for wp.updates.showErrorInCredentialsForm`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31528#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform