[wp-trac] [WordPress Trac] #31528: Shiny Updates: FTP Support

[WordPress Trac]

#31528: Shiny Updates: FTP Support
-------------------------------------+-------------------------------------
 Reporter:  pento                    |       Owner:  ericlewis
     Type:  task (blessed)           |      Status:  reopened
 Priority:  normal                   |   Milestone:  4.2
Component:  Upgrade/Install          |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  shiny-updates needs-     |     Focuses:  ui, javascript,
  patch                              |  administration
-------------------------------------+-------------------------------------
Changes (by johnbillion):

 * keywords:  shiny-updates => shiny-updates needs-patch
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 r31749 is a concern.

 `script-loader.php` is a file which gets included in `load-scripts.php`
 and `load-styles.php`, our script and style concatenators.

 Since r31749 `script-loader.php` now calls
 `request_filesystem_credentials()` directly, which in turns calls
 `get_filesystem_method()`, a function which performs a write, read, close,
 and delete action on a temporary file (unless you've manually defined
 `WP_FS_METHOD`).

 We need a better way of determining whether we need to request filesystem
 credentials. My suggestion would be to trigger an AJAX request which
 returns the result of `request_filesystem_credentials()`, rather than
 calling `request_filesystem_credentials()` in `script-loader.php` just to
 populate a JS boolean.

 I don't think beta 1 should ship with the current code.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31528#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform