[wp-trac] [WordPress Trac] #31166: wpmu_signup_user_notification filter is incorrect

[WordPress Trac]

#31166: wpmu_signup_user_notification filter is incorrect
------------------------------------+------------------------------
 Reporter:  johnrom                 |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Login and Registration  |     Version:  3.0
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback            |     Focuses:  multisite
------------------------------------+------------------------------
Changes (by jeremyfelt):

 * keywords:   => dev-feedback


Comment:

 It could be tough to really deprecate the filter as you'd always need to
 account for it.

 A new filter would likely go immediately after the current filter. Then if
 using the new filter, you would need to `add_filter(
 'wpmu_signup_blog_notification', '__return_true', 999 );` to try and
 overrule any previous use before hooking in to
 `new_wpmu_signup_blog_notification`.

 Part of me wants to wontfix. While somewhat annoying, if a plugin has a
 notification that ''really'' needs to fire, a `if ( ! $user ) { // find
 user by email or key from signups table }` could do the trick.

 I could go either way though. :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31166#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform