[wp-trac] [WordPress Trac] #31528: Shiny Updates: FTP Support

[WordPress Trac]

#31528: Shiny Updates: FTP Support
-----------------------------+---------------------------------------------
 Reporter:  pento            |       Owner:  ericlewis
     Type:  task (blessed)   |      Status:  assigned
 Priority:  normal           |   Milestone:  4.2
Component:  Upgrade/Install  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  shiny-updates    |     Focuses:  ui, javascript, administration
-----------------------------+---------------------------------------------

Comment (by ericlewis):

 attachment:31528.diff is a work in progress.

 It *should* work for updating a plugin and inputting FTP/SSH credentials.
 I haven't tested it yet because I don't have an FTP server in my Varying
 Vagrant Vagrants setup I use for core development (as far as I know).

 Other notes:
 * Before page load, do some intelligent things to decide whether we need
 to request filesystem credentials. When the user makes an action (e.g.
 upgrade plugin) that requires credentials, offer them a form to fill out
 to do this.
 * Going with a modal for the moment. We discussed a "terrestrial" form at
 the top of the page in case the user doesn't have `direct` as the
 filesystem method. This would be awkward if the user is going to the
 Plugin list table and we proffer a form at the top when their goal is to
 deactivate a plugin, but we put it there in case they want to upgrade a
 plugin.
 * Rewrote some of the update plugin endpoint logic to return an error if
 filesystem connection failed. I wonder if we should repeatedly request
 credentials if this failure occurs (i.e. if the user is messing up while
 inputting their FTP credentials). We probably should.
 * No styling at the moment, Functionality First™.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31528#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform