[wp-trac] [WordPress Trac] #31557: Blog details are misplaced in title tag with "left" separator location

[WordPress Trac]

#31557: Blog details are misplaced in title tag with "left" separator location
-----------------------------+------------------------------
 Reporter:  johnjamesjacoby  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Themes           |     Version:
 Severity:  normal           |  Resolution:
 Keywords:                   |     Focuses:
-----------------------------+------------------------------

Comment (by johnjamesjacoby):

 [https://core.trac.wordpress.org/attachment/ticket/31557/31557.01.patch
 31557.01.patch] touches a fair amount of code to fix this in a way that is
 backwards compatible with all core themes and popular plugins. The
 BuddyPress team has also done a fair amount of research into this over on
 [https://buddypress.trac.wordpress.org/ticket/6107 BuddyPress #6107].

 In short, the copy/pasted code from Underscores and the core themes
 derived from it did not take into account `left` separator location, since
 they have all always used `right`.

 On the feedback end of this all, the Underscores blog details portion
 should probably have been separated from the recent `title-tag` feature,
 maybe even on a different ticket to be explicit about the problem it
 solved. Combining those two changes made this more difficult to debug
 instead of easier.

 Also note the commit message does not mention that `wp_title()` now has a
 third output permutation supported by core themes, which required studying
 up on 4 years worth of discussion to comprehend what the intentions were,
 and how and why they were not fully met.

 Given the complexity and fragility of the `wp_title()` function, we may
 want to invest some time in writing a bevy of unit tests to ensure its
 output remains consistent through-out future modifications being thought
 through on #31078.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31557#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform