[wp-trac] [WordPress Trac] #31527: Twenty Fifteen: Add ARIA attributes to menu toggle
WordPress Trac
noreply at wordpress.org
Fri Mar 6 17:18:20 UTC 2015
#31527: Twenty Fifteen: Add ARIA attributes to menu toggle
-------------------------------------+----------------------------
Reporter: davidakennedy | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 4.2
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch needs-testing | Focuses: accessibility
-------------------------------------+----------------------------
Comment (by davidakennedy):
Replying to [comment:4 lancewillett]:
> Ignore wrong patch, sorry. ;)
>
> .2 patch changes things a tiny bit:
>
> 1. Move event handlers to main `ready` clause and add `twentyfifteen`
namespace.
> 1. Move `onResizeARIA()` function out of anonymous function so it can
be called from elsewhere in the file.
> 1. Declare `secondary` and `button` variables earlier in the file so
they can be used in any function.
Thanks for cleaning the patch up and making it better, @lancewillett!
Everything works as expected. I'll work this weekend on getting this type
of patch into other default themes.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/31527#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list